gyfora commented on code in PR #21247:
URL: https://github.com/apache/flink/pull/21247#discussion_r1018881122


##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaInternalProducerITCase.java:
##########
@@ -204,7 +204,7 @@ public void testFlushAfterClosed() {
 
     @Test(timeout = 30000L)
     public void 
testProducerWhenCommitEmptyPartitionsToOutdatedTxnCoordinator() throws 
Exception {
-        String topic = "flink-kafka-producer-txn-coordinator-changed";
+        String topic = "flink-kafka-producer-txn-coordinator-changed-" + 
UUID.randomUUID();

Review Comment:
   I think the point here is that adding randomness in general doesn't hurt, it 
might not be strictly necessary everwhere but it's easier to add it everywhere 
to fix the test instability which is a very urgent matter.
   
   Let's go ahead with the current implementation, if someone want's to improve 
this further we can do it once the instabilities are gone.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to