gaborgsomogyi commented on code in PR #434:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/434#discussion_r1019258482


##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/FlinkOperatorTest.java:
##########
@@ -74,4 +93,16 @@ public void testConfigurationPassedToJOSDK() {
 
         Assertions.assertThrows(IllegalStateException.class, () -> new 
FlinkOperator(secondConfig));
     }
+
+    @Test
+    public void testLeaderElectionConfig() {
+        var operatorConfig = new Configuration();
+        
operatorConfig.set(KubernetesOperatorConfigOptions.OPERATOR_LEADER_ELECTION_ENABLED,
 true);
+
+        try {
+            new FlinkOperator(operatorConfig);
+        } catch (IllegalConfigurationException ice) {
+            assertTrue(ice.getMessage().startsWith("Lease name must be 
defined"));

Review Comment:
   Oh, now see that the feature later mentioned. Maybe adding the key would 
provide more convenience.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to