gaborgsomogyi commented on code in PR #439:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/439#discussion_r1023673893
##########
flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/SavepointInfo.java:
##########
@@ -63,7 +63,7 @@ public void setTrigger(
}
public void resetTrigger() {
- this.triggerId = "";
+ this.triggerId = null;
this.triggerTimestamp = 0L;
Review Comment:
Adding this would end-up in additional code like null checks, etc..., but
what would be the benefit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
