morhidi commented on code in PR #439:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/439#discussion_r1024152777
##########
flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/SavepointInfo.java:
##########
@@ -63,7 +63,7 @@ public void setTrigger(
}
public void resetTrigger() {
- this.triggerId = "";
+ this.triggerId = null;
this.triggerTimestamp = 0L;
Review Comment:
It'll keep already stored `0` values however, so no business logic should
check `(triggerTimestamp == null)`, it'll be `0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
