JingGe commented on code in PR #21322:
URL: https://github.com/apache/flink/pull/21322#discussion_r1027686571
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/TableConfigOptions.java:
##########
@@ -102,6 +102,16 @@ private TableConfigOptions() {}
+ "the session time zone is used during
conversion. The input of option is either a full name "
+ "such as \"America/Los_Angeles\", or a
custom timezone id such as \"GMT-08:00\".");
+ @Documentation.TableOption(execMode = Documentation.ExecMode.STREAMING)
+ public static final ConfigOption<Integer> PRINT_MAX_COLUMN_WIDTH =
Review Comment:
Current modification is focusing on the Table API. Although sql-client will
call Table API, the use case and target users of using sql-client and Table API
are different. I am not sure if it makes sense to use
`table.print.max-column-width` as the fallback of
`sql-client.display.max-column-width` and keep them sync because
`sql-client.display.max-column-width` can be updated. @wuchong @godfreyhe may I
have your thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
