[GitHub] [flink] JingGe commented on a diff in pull request #21322: [FLINK-30025][table] the max column width should be resizable while printing the query result to the client console.

Mon, 21 Nov 2022 00:41:03 -0800 


JingGe commented on code in PR #21322:
URL: https://github.com/apache/flink/pull/21322#discussion_r1027716672


##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java:
##########
@@ -926,7 +926,7 @@ private TableResultInternal 
executeQueryOperation(QueryOperation operation) {
                                     DataTypeUtils.expandCompositeTypeToSchema(
                                             
sinkOperation.getConsumedDataType()),
                                     resultProvider.getRowDataStringConverter(),
-                                    PrintStyle.DEFAULT_MAX_COLUMN_WIDTH,

Review Comment:
   Since sql-client.display.max-column-width only used for 
`ExecMode.STREAMING`, this PR is only focusing on `ExecMode.STREAMING`. 
`PrintStyle.DEFAULT_MAX_COLUMN_WIDTH` will still be used for `ExecMode.BATCH`
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to