1996fanrui opened a new pull request, #21432:
URL: https://github.com/apache/flink/pull/21432

   ## What is the purpose of the change
   
   When the flame graph type is switched from On-CPU to Mixed. It still show 
the graph of On-CPU.
   
   Root cause:
   When click the other types, the web frontend will call the requestFlameGraph 
and update the graphType. However, the graphType is the old type during 
requestFlameGraph. So the graph type show the new type, but the flame graph is 
the result of old type.
   
   
https://github.com/apache/flink/blob/8bbf52688758bbede45df060a4c11e5fa228b6f0/flink-runtime-web/web-dashboard/src/app/pages/job/overview/flamegraph/job-overview-drawer-flamegraph.component.ts#L82
   
   
   ## Brief change log
   
   Using the new graph type when request the flameGraph.
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not documented
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to