yangjunhan commented on code in PR #21432:
URL: https://github.com/apache/flink/pull/21432#discussion_r1044187607
##########
flink-runtime-web/web-dashboard/src/app/pages/job/overview/flamegraph/job-overview-drawer-flamegraph.component.ts:
##########
@@ -50,12 +50,13 @@ import { JobLocalService } from '../../job-local.service';
standalone: true
})
export class JobOverviewDrawerFlameGraphComponent implements OnInit, OnDestroy
{
+ FlameGraphType = FlameGraphType;
Review Comment:
```suggestion
readonly FlameGraphType = FlameGraphType;
```
##########
flink-runtime-web/web-dashboard/src/app/pages/job/overview/flamegraph/job-overview-drawer-flamegraph.component.ts:
##########
@@ -66,20 +67,20 @@ export class JobOverviewDrawerFlameGraphComponent
implements OnInit, OnDestroy {
) {}
public ngOnInit(): void {
- this.requestFlameGraph();
+ this.requestFlameGraph(this.graphType);
Review Comment:
```suggestion
this.requestFlameGraph(FlameGraphType.ON_CPU);
```
##########
flink-runtime-web/web-dashboard/src/app/pages/job/overview/flamegraph/job-overview-drawer-flamegraph.component.ts:
##########
@@ -50,12 +50,13 @@ import { JobLocalService } from '../../job-local.service';
standalone: true
})
export class JobOverviewDrawerFlameGraphComponent implements OnInit, OnDestroy
{
+ FlameGraphType = FlameGraphType;
public isLoading = true;
public now = Date.now();
public selectedVertex: NodesItemCorrect | null;
public flameGraph = {} as JobFlameGraph;
- public graphType = 'on_cpu';
+ public graphType = FlameGraphType.ON_CPU;
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
