gyfora commented on code in PR #464: URL: https://github.com/apache/flink-kubernetes-operator/pull/464#discussion_r1038512952
########## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/exception/RecoverableDeploymentFailureException.java: ########## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.kubernetes.operator.exception; + +/** Exception to signal non-terminal deployment failure. */ +public class RecoverableDeploymentFailureException extends DeploymentFailedException { Review Comment: Let’s not extend DeploymentFailedException , the deployment does not fail in these cases (the jobmanager deployment I mean) we could simply call FlinkResourceException or something more generic ########## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentController.java: ########## @@ -139,10 +142,13 @@ public UpdateControl<FlinkDeployment> reconcile(FlinkDeployment flinkApp, Contex configManager.getOperatorConfiguration(), flinkApp, previousDeployment, true); } - private void handleDeploymentFailed(FlinkDeployment flinkApp, DeploymentFailedException dfe) { + private void handleDeploymentFailed( + FlinkDeployment flinkApp, DeploymentFailedException dfe, boolean updateJobStatus) { LOG.error("Flink Deployment failed", dfe); - flinkApp.getStatus().setJobManagerDeploymentStatus(JobManagerDeploymentStatus.ERROR); - flinkApp.getStatus().getJobStatus().setState(JobStatus.RECONCILING.name()); + if (updateJobStatus) { Review Comment: These should be two separate methods, the update status flag does not have any well defined meaning I feel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
