gyfora commented on code in PR #464:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/464#discussion_r1039563266
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconciler.java:
##########
@@ -125,7 +125,7 @@ protected Optional<UpgradeMode> getAvailableUpgradeMode(
if (status.getJobManagerDeploymentStatus() ==
JobManagerDeploymentStatus.MISSING
|| status.getJobManagerDeploymentStatus() ==
JobManagerDeploymentStatus.ERROR) {
- throw new DeploymentFailedException(
+ throw new RecoveryFailureException(
"JobManager deployment is missing and HA data is not
available to make stateful upgrades. "
+ "It is possible that the job has finished or
terminally failed, or the configmaps have been deleted. "
+ "Manual restore required.",
Review Comment:
There could be some error cases where we still recover I guess , but we
would have to check. In that case that would recover automatically. But missing
I think is final in this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
