[GitHub] [flink] snuyanzin commented on pull request #21490: [FLINK-30368][table-planner] Fix calcite method RelMdUtil$numDistinctVals() wrongly return zero if the method input domainSize much larger than numSelected

Mon, 12 Dec 2022 01:27:30 -0800 


snuyanzin commented on PR #21490:
URL: https://github.com/apache/flink/pull/21490#issuecomment-1346155848

   Thanks for your contribution
   Could you please clarify how we can be sure that this change does what 
expected?
   May be some tests could be helpful to have.
   
   Also it would be helpful to have info about what lines are changed in this 
class, like it is done e.g. in `RexSimplify`, `SqlToRelConverter` and other 
Calcite's classes
   
   And another question: shouldn't this issue be raised in Calcite's jira?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to