snuyanzin commented on code in PR #21410:
URL: https://github.com/apache/flink/pull/21410#discussion_r1047215604
##########
flink-state-backends/flink-statebackend-changelog/src/test/java/org/apache/flink/state/changelog/ChangelogDelegateHashMapInMemoryTest.java:
##########
@@ -22,17 +22,12 @@
import org.apache.flink.runtime.state.TestTaskStateManager;
import
org.apache.flink.runtime.state.changelog.inmemory.InMemoryStateChangelogStorage;
-import org.junit.Rule;
-import org.junit.rules.TemporaryFolder;
-
/**
* Tests for {@link ChangelogStateBackend} using {@link
InMemoryStateChangelogStorage} and
* delegating {@link HashMapStateBackendTest}.
*/
public class ChangelogDelegateHashMapInMemoryTest extends
ChangelogDelegateHashMapTest {
Review Comment:
```suggestion
class ChangelogDelegateHashMapInMemoryTest extends
ChangelogDelegateHashMapTest {
```
could be package private
##########
flink-state-backends/flink-statebackend-changelog/src/test/java/org/apache/flink/state/changelog/ChangelogDelegateHashMapTest.java:
##########
@@ -32,19 +32,19 @@
import org.apache.flink.runtime.state.StateBackend;
import org.apache.flink.runtime.state.TestTaskStateManager;
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.TemporaryFolder;
+import org.junit.jupiter.api.TestTemplate;
+import org.junit.jupiter.api.io.TempDir;
+import java.io.File;
import java.io.IOException;
/** Tests for {@link ChangelogStateBackend} delegating {@link
HashMapStateBackendTest}. */
public class ChangelogDelegateHashMapTest extends HashMapStateBackendTest {
Review Comment:
```suggestion
class ChangelogDelegateHashMapTest extends HashMapStateBackendTest {
```
could be package private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
