snuyanzin commented on code in PR #21410:
URL: https://github.com/apache/flink/pull/21410#discussion_r1047220616
##########
flink-state-backends/flink-statebackend-changelog/src/test/java/org/apache/flink/state/changelog/ChangelogStateBackendLoadingTest.java:
##########
@@ -58,75 +58,73 @@
import org.apache.flink.util.Collector;
import org.apache.flink.util.TernaryBoolean;
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.TemporaryFolder;
+import org.junit.jupiter.api.Test;
import javax.annotation.Nonnull;
import java.util.Collection;
import java.util.Collections;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNull;
-import static org.junit.Assert.assertSame;
-import static org.junit.Assert.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+import static org.junit.jupiter.api.Assertions.assertSame;
/** Verify Changelog StateBackend is properly loaded. */
public class ChangelogStateBackendLoadingTest {
- @Rule public final TemporaryFolder tmp = new TemporaryFolder();
-
private final ClassLoader cl = getClass().getClassLoader();
private final String backendKey = StateBackendOptions.STATE_BACKEND.key();
@Test
- public void testLoadingDefault() throws Exception {
+ void testLoadingDefault() throws Exception {
final StateBackend backend =
StateBackendLoader.fromApplicationOrConfigOrDefault(
null, TernaryBoolean.UNDEFINED, config(), cl, null);
final CheckpointStorage storage =
CheckpointStorageLoader.load(null, null, backend, config(),
cl, null);
-
- assertTrue(backend instanceof HashMapStateBackend);
+ assertThat(backend instanceof HashMapStateBackend).isTrue();
Review Comment:
```suggestion
assertThat(backend).isInstanceOf(HashMapStateBackend.class);
```
could be simplified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
