swuferhong commented on code in PR #21487:
URL: https://github.com/apache/flink/pull/21487#discussion_r1057032129
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkJoinToMultiJoinRule.java:
##########
@@ -378,25 +513,53 @@ private List<RexNode> combineJoinFilters(Join join,
RelNode left, RelNode right)
* @param nullGenerating true if the input is null generating
* @return true if the input can be combined into a parent MultiJoin
*/
- private boolean canCombine(RelNode input, JoinRelType joinType, boolean
nullGenerating) {
+ private boolean canCombine(
+ RelNode input,
+ ImmutableIntList joinKeys,
+ JoinRelType joinType,
+ boolean nullGenerating,
+ boolean isLeft,
+ List<Boolean> inputNullGenFieldList,
+ int beginIndex) {
+ if (inputNullGenFieldList == null) {
+ // semi and anti join
Review Comment:
> inputNullGenFieldList is never null
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
