swuferhong commented on code in PR #21487:
URL: https://github.com/apache/flink/pull/21487#discussion_r1057034318
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/rules/logical/FlinkJoinToMultiJoinRuleTest.scala:
##########
@@ -268,4 +291,19 @@ class FlinkJoinToMultiJoinRuleTest extends TableTestBase {
""".stripMargin
util.verifyRelPlan(sqlQuery)
}
+
+ @Test
+ def testMultiLeftOuterJoinWithAllKeyInLeft: Unit = {
Review Comment:
semi and anti now can not join reorder, so it will not go into `onMatch()`
method because of `origJoin.getJoinType().projectsRight()` in `matches()`. So I
think the branch `inputNullGenFieldList.isEmpty()` in `canCombine()` is useless
and I will remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
