godfreyhe commented on code in PR #21545:
URL: https://github.com/apache/flink/pull/21545#discussion_r1057055251
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/hint/FlinkHints.java:
##########
@@ -189,18 +191,33 @@ public static RelNode capitalizeJoinHints(RelNode root) {
private static class CapitalizeJoinHintShuttle extends RelShuttleImpl {
+ @Override
+ public RelNode visit(LogicalCorrelate correlate) {
+ return visitBiRel(correlate);
+ }
+
@Override
public RelNode visit(LogicalJoin join) {
- List<RelHint> hints = join.getHints();
+ return visitBiRel(join);
+ }
+
+ private RelNode visitBiRel(BiRel biRel) {
+ Hintable hBiRel = (Hintable) biRel;
AtomicBoolean changed = new AtomicBoolean(false);
List<RelHint> hintsWithCapitalJoinHints =
- hints.stream()
+ hBiRel.getHints().stream()
.map(
hint -> {
String capitalHintName =
hint.hintName.toUpperCase(Locale.ROOT);
if
(JoinStrategy.isJoinStrategy(capitalHintName)) {
changed.set(true);
+ if
(JoinStrategy.isLookupHint(hint.hintName)) {
Review Comment:
can you add some tests to verify this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
