lincoln-lil commented on code in PR #21545:
URL: https://github.com/apache/flink/pull/21545#discussion_r1056946337
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/alias/ClearJoinHintWithInvalidPropagationShuttle.java:
##########
@@ -66,7 +78,7 @@ public RelNode visit(LogicalJoin join) {
// there are no alias hints on this Join node
Review Comment:
nit: Join -> Join / Correlate
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/alias/ClearJoinHintWithInvalidPropagationShuttle.java:
##########
@@ -49,14 +52,23 @@ public class ClearJoinHintWithInvalidPropagationShuttle
extends RelShuttleImpl {
@Override
public RelNode visit(LogicalJoin join) {
- List<RelHint> hints = join.getHints();
+ return visitBiRel(join);
+ }
+
+ @Override
+ public RelNode visit(LogicalCorrelate correlate) {
+ return visitBiRel(correlate);
+ }
+
+ private RelNode visitBiRel(BiRel biRel) {
+ List<RelHint> hints = ((Hintable) biRel).getHints();
Set<String> allHintNames =
hints.stream().map(hint ->
hint.hintName).collect(Collectors.toSet());
// there are no join hints on this Join node
Review Comment:
nit: Join -> Join / Correlate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
