zjureel commented on PR #441: URL: https://github.com/apache/flink-table-store/pull/441#issuecomment-1366461811
> Hi @zjureel , thanks for the update. > > * I still think we can introduce a `CastExecutors` class, each cast is a separate internal class or anonymous internal class inside, and we don't need `CastExecutorProvider` anymore, static methods are provided directly inside `CastExecutors`. > * I don't need to bring a null check to every cast, we can let the caller take care of the null check himself. Nice, I think it will be much more concise 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
