[
https://issues.apache.org/jira/browse/FLINK-30234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653814#comment-17653814
]
Wencong Liu commented on FLINK-30234:
-------------------------------------
The discussion has been created. cc [~renqs]
[[DISCUSS] Allow source readers extending SourceReaderBase to override
numRecordsIn report logic-Apache Mail
Archives|https://lists.apache.org/thread/pq7vrqc1vjbzj6of4wm5x8x7pkpdchox]
> SourceReaderBase should provide an option to disable numRecordsIn metric
> registration
> -------------------------------------------------------------------------------------
>
> Key: FLINK-30234
> URL: https://issues.apache.org/jira/browse/FLINK-30234
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / Common
> Affects Versions: 1.17.0
> Reporter: Qingsheng Ren
> Assignee: Wencong Liu
> Priority: Major
>
> Currently the numRecordsIn metric is pre-registered for all sources in
> SourceReaderBase. Considering different implementation of source reader, the
> definition of "record" might differ from the one we use in SourceReaderBase,
> hence numRecordsIn might be inaccurate.
> We could introduce an option in SourceReader to disable the registration of
> numRecordsIn in SourceReaderBase and let the actual implementation to report
> the metric instead.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
