rkhachatryan commented on code in PR #21467:
URL: https://github.com/apache/flink/pull/21467#discussion_r1060981282
##########
flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/DefaultHeartbeatMonitor.java:
##########
@@ -35,9 +36,9 @@
*
* @param <O> Type of the payload being sent to the associated heartbeat target
*/
-public class HeartbeatMonitorImpl<O> implements HeartbeatMonitor<O>, Runnable {
+public class DefaultHeartbeatMonitor<O> implements HeartbeatMonitor<O>,
Runnable {
Review Comment:
To me, `*Impl` is **slightly** better, because `*Default` implies that there
are non-default **production** implementations (which is not the case here).
But here, consistency is more important.
Not sure if this (either `*Impl` or `*Default`) worth a naming convention
and renaming the existing classes. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
