rkhachatryan commented on code in PR #21467:
URL: https://github.com/apache/flink/pull/21467#discussion_r1060998267
##########
flink-core/src/main/java/org/apache/flink/configuration/HeartbeatManagerOptions.java:
##########
@@ -50,6 +50,8 @@ public class HeartbeatManagerOptions {
private static final String HEARTBEAT_RPC_FAILURE_THRESHOLD_KEY =
"heartbeat.rpc-failure-threshold";
+ public static final int FAILED_RPC_DETECTION_DISABLED = -1;
Review Comment:
I probably misunderstood your
[suggestion](https://github.com/apache/flink/pull/21467#discussion_r1055229084)
then :)
But I do think that`HeartbeatManagerOptions` is the right place for this
constant because:
- this `-1` is a part of the contract with the user, so it originates here
- the implementation classes must check their arguments against exactly the
same constant
Furthremore, I think `HeartbeatManagerOptions` is production code as well
(because it's necessary in production). Did you mean runtime or implementation
instead?
Moving this options class closer to the implementation also makes sense to
me (but I'd still keep the constant there).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
