wanglijie95 commented on code in PR #21570:
URL: https://github.com/apache/flink/pull/21570#discussion_r1062193741
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/VertexParallelismDecider.java:
##########
@@ -18,19 +18,27 @@
package org.apache.flink.runtime.scheduler.adaptivebatch;
+import org.apache.flink.api.common.ExecutionConfig;
+import org.apache.flink.runtime.executiongraph.JobVertexInputInfo;
+import org.apache.flink.runtime.executiongraph.ParallelismAndInputInfos;
+
import java.util.List;
/**
- * {@link VertexParallelismDecider} is responsible for determining the
parallelism of a job vertex,
- * based on the size of the consumed blocking results.
+ * {@link VertexParallelismDecider} is responsible for deciding the
parallelism and {@link
+ * JobVertexInputInfo}s of a job vertex, based on the information of the
consumed blocking results.
*/
public interface VertexParallelismDecider {
/**
- * Computing the parallelism.
+ * Decide the parallelism and {@link JobVertexInputInfo}s for this job
vertex.
*
- * @param consumedResults The information of consumed blocking results.
- * @return the parallelism of the job vertex.
+ * @param inputs The information of consumed blocking results
Review Comment:
Fixed
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/VertexParallelismDecider.java:
##########
@@ -18,19 +18,27 @@
package org.apache.flink.runtime.scheduler.adaptivebatch;
+import org.apache.flink.api.common.ExecutionConfig;
+import org.apache.flink.runtime.executiongraph.JobVertexInputInfo;
+import org.apache.flink.runtime.executiongraph.ParallelismAndInputInfos;
+
import java.util.List;
/**
- * {@link VertexParallelismDecider} is responsible for determining the
parallelism of a job vertex,
- * based on the size of the consumed blocking results.
+ * {@link VertexParallelismDecider} is responsible for deciding the
parallelism and {@link
+ * JobVertexInputInfo}s of a job vertex, based on the information of the
consumed blocking results.
*/
public interface VertexParallelismDecider {
/**
- * Computing the parallelism.
+ * Decide the parallelism and {@link JobVertexInputInfo}s for this job
vertex.
*
- * @param consumedResults The information of consumed blocking results.
- * @return the parallelism of the job vertex.
+ * @param inputs The information of consumed blocking results
+ * @param parallelism The original parallelism of the job vertex, used to
determine whether the
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
