wanglijie95 commented on code in PR #21570:
URL: https://github.com/apache/flink/pull/21570#discussion_r1062195219
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/DefaultVertexParallelismDecider.java:
##########
@@ -77,46 +92,74 @@ private DefaultVertexParallelismDecider(
}
@Override
- public int decideParallelismForVertex(List<BlockingResultInfo>
consumedResults) {
+ public ParallelismAndInputInfos decideParallelismAndInputInfosForVertex(
+ List<BlockingResultInfo> inputs, int parallelism) {
+ checkArgument(parallelism == ExecutionConfig.PARALLELISM_DEFAULT ||
parallelism > 0);
- if (consumedResults.isEmpty()) {
+ if (inputs.isEmpty()) {
// source job vertex
- return defaultSourceParallelism;
+ return new ParallelismAndInputInfos(defaultSourceParallelism,
Collections.emptyMap());
+ } else if (parallelism == ExecutionConfig.PARALLELISM_DEFAULT
+ && areAllInputsAllToAll(inputs)
+ && !areAllInputsBroadcast(inputs)) {
+ // load balance for ALL_TO_ALL inputs
+ return loadBalanceForAllToAllInputs(inputs, parallelism);
} else {
- return calculateParallelism(consumedResults);
+ if (parallelism == ExecutionConfig.PARALLELISM_DEFAULT) {
+ parallelism = decideParallelism(inputs);
+ }
+ return new ParallelismAndInputInfos(parallelism,
decideInputInfos(inputs, parallelism));
}
}
- private int calculateParallelism(List<BlockingResultInfo> consumedResults)
{
+ private static boolean areAllInputsAllToAll(List<BlockingResultInfo>
inputs) {
+ return inputs.stream().noneMatch(BlockingResultInfo::isPointwise);
+ }
- long broadcastBytes =
- consumedResults.stream()
- .filter(BlockingResultInfo::isBroadcast)
- .mapToLong(BlockingResultInfo::getNumBytesProduced)
- .sum();
+ private static boolean areAllInputsBroadcast(List<BlockingResultInfo>
inputs) {
+ return inputs.stream().allMatch(BlockingResultInfo::isBroadcast);
+ }
- long nonBroadcastBytes =
- consumedResults.stream()
- .filter(consumedResult ->
!consumedResult.isBroadcast())
- .mapToLong(BlockingResultInfo::getNumBytesProduced)
- .sum();
+ static Map<IntermediateDataSetID, JobVertexInputInfo> decideInputInfos(
Review Comment:
Use `VertexInputInfoComputationUtils.computeVertexInputInfos(...)` instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
