gaborgsomogyi commented on code in PR #21604:
URL: https://github.com/apache/flink/pull/21604#discussion_r1062455662


##########
flink-runtime/src/main/java/org/apache/flink/runtime/security/token/hadoop/HBaseDelegationTokenProvider.java:
##########
@@ -91,6 +90,22 @@ private org.apache.hadoop.conf.Configuration 
getHBaseConfiguration(Configuration
 
     @Override
     public boolean delegationTokensRequired() throws Exception {
+        /**
+         * The general rule how a provider/receiver must behave is the 
following: The provider and
+         * the receiver must be added to the classpath together with all the 
additionally required
+         * dependencies.
+         *
+         * <p>This null check is required because the HBase provider is always 
on classpath but
+         * HBase jars are optional. Such case configuration is not able to be 
loaded. This construct
+         * is intended to be removed when HBase provider/receiver pair can be 
externalized (namely
+         * if a provider/receiver throws an exception then workload must be 
stopped).
+         */
+        if (hbaseConf == null) {
+            LOG.debug(
+                    "HBase is not available (not packaged with this 
application), hence no "
+                            + "tokens will be acquired.");
+            return false;
+        }

Review Comment:
   This is temporary solution as mentioned before.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to