gaborgsomogyi commented on code in PR #21604:
URL: https://github.com/apache/flink/pull/21604#discussion_r1062653461
##########
flink-runtime/src/main/java/org/apache/flink/runtime/security/token/DefaultDelegationTokenManager.java:
##########
@@ -118,10 +133,13 @@ private Map<String, DelegationTokenProvider>
loadProviders() {
provider.serviceName());
}
} catch (Exception | NoClassDefFoundError e) {
- LOG.warn(
+ // The intentional general rule is that if a provider's init
method throws exception
+ // then stop the workload
+ LOG.error(
"Failed to initialize delegation token provider {}",
provider.serviceName(),
e);
+ throw new RuntimeException(e);
Review Comment:
Makes sense to use `FlinkRuntimeException`, changed on both places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
