luoyuxia commented on code in PR #21556:
URL: https://github.com/apache/flink/pull/21556#discussion_r1063970639
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveSourceFileEnumerator.java:
##########
@@ -222,19 +225,24 @@ private static int getThreadNumToSplitHiveFile(JobConf
jobConf) {
/** A factory to create {@link HiveSourceFileEnumerator}. */
public static class Provider implements FileEnumerator.Provider {
+ private static final Logger LOG =
LoggerFactory.getLogger(Provider.class);
+
private static final long serialVersionUID = 1L;
- private final List<HiveTablePartition> partitions;
+ private final List<byte[]> partitionBytes;
private final JobConfWrapper jobConfWrapper;
- public Provider(List<HiveTablePartition> partitions, JobConfWrapper
jobConfWrapper) {
- this.partitions = partitions;
+ public Provider(List<byte[]> partitionBytes, JobConfWrapper
jobConfWrapper) {
+ this.partitionBytes = partitionBytes;
this.jobConfWrapper = jobConfWrapper;
}
@Override
public FileEnumerator create() {
- return new HiveSourceFileEnumerator(partitions,
jobConfWrapper.conf());
+ LOG.info("Deserialize hive table partition in
HiveSourceFileEnumerator.");
Review Comment:
Do we really need to log this?
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveSourceDynamicFileEnumerator.java:
##########
@@ -187,31 +187,36 @@ public static class Provider implements
DynamicFileEnumerator.Provider {
private static final long serialVersionUID = 1L;
+ private static final Logger LOG =
LoggerFactory.getLogger(Provider.class);
+
private final String table;
private final List<String> dynamicFilterPartitionKeys;
- private final List<HiveTablePartition> partitions;
+ private final List<byte[]> partitionBytes;
private final String hiveVersion;
private final JobConfWrapper jobConfWrapper;
public Provider(
String table,
List<String> dynamicFilterPartitionKeys,
- List<HiveTablePartition> partitions,
+ List<byte[]> partitionBytes,
String hiveVersion,
JobConfWrapper jobConfWrapper) {
this.table = checkNotNull(table);
this.dynamicFilterPartitionKeys =
checkNotNull(dynamicFilterPartitionKeys);
- this.partitions = checkNotNull(partitions);
+ this.partitionBytes = checkNotNull(partitionBytes);
this.hiveVersion = checkNotNull(hiveVersion);
this.jobConfWrapper = checkNotNull(jobConfWrapper);
}
@Override
public DynamicFileEnumerator create() {
+ LOG.info(
Review Comment:
Do we really need to log this? If so, I think the log may be
`Deserialize hive table partition for table {} in
HiveSourceDynamicFileEnumerator.`
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveSourceDynamicFileEnumerator.java:
##########
@@ -187,31 +187,36 @@ public static class Provider implements
DynamicFileEnumerator.Provider {
private static final long serialVersionUID = 1L;
+ private static final Logger LOG =
LoggerFactory.getLogger(Provider.class);
+
private final String table;
private final List<String> dynamicFilterPartitionKeys;
- private final List<HiveTablePartition> partitions;
+ private final List<byte[]> partitionBytes;
Review Comment:
Add a comment for this field?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
