lsyldliu commented on code in PR #21556:
URL: https://github.com/apache/flink/pull/21556#discussion_r1064259298
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveSourceDynamicFileEnumerator.java:
##########
@@ -187,31 +187,36 @@ public static class Provider implements
DynamicFileEnumerator.Provider {
private static final long serialVersionUID = 1L;
+ private static final Logger LOG =
LoggerFactory.getLogger(Provider.class);
+
private final String table;
private final List<String> dynamicFilterPartitionKeys;
- private final List<HiveTablePartition> partitions;
+ private final List<byte[]> partitionBytes;
private final String hiveVersion;
private final JobConfWrapper jobConfWrapper;
public Provider(
String table,
List<String> dynamicFilterPartitionKeys,
- List<HiveTablePartition> partitions,
+ List<byte[]> partitionBytes,
String hiveVersion,
JobConfWrapper jobConfWrapper) {
this.table = checkNotNull(table);
this.dynamicFilterPartitionKeys =
checkNotNull(dynamicFilterPartitionKeys);
- this.partitions = checkNotNull(partitions);
+ this.partitionBytes = checkNotNull(partitionBytes);
this.hiveVersion = checkNotNull(hiveVersion);
this.jobConfWrapper = checkNotNull(jobConfWrapper);
}
@Override
public DynamicFileEnumerator create() {
+ LOG.info(
Review Comment:
After rethinking, we don't need this log, if deserializing the hive table
partition fails, the exception will be thrown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
