tisonkun commented on code in PR #19:
URL:
https://github.com/apache/flink-connector-pulsar/pull/19#discussion_r1070490107
##########
flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/reader/deserializer/PulsarDeserializationSchema.java:
##########
@@ -70,80 +66,4 @@ default void open(InitializationContext context,
SourceConfiguration configurati
* @param out The collector to put the resulting messages.
*/
void deserialize(Message<byte[]> message, Collector<T> out) throws
Exception;
-
- /**
- * Create a PulsarDeserializationSchema by using the flink's {@link
DeserializationSchema}. It
- * would consume the pulsar message as the byte array and decode the
message by using flink's
- * logic.
- *
- * @deprecated Use {@link
PulsarSourceBuilder#setDeserializationSchema(DeserializationSchema)}
- * instead.
- */
- @Deprecated
- static <T> PulsarDeserializationSchema<T> flinkSchema(
Review Comment:
... while these methods are not buggy. While it's possible to remove in the
next major version, I wonder why we do this change and it'd better we prevent
further changes like such rename things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
