syhily commented on code in PR #19:
URL:
https://github.com/apache/flink-connector-pulsar/pull/19#discussion_r1070538459
##########
flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/cursor/StartCursor.java:
##########
@@ -73,18 +73,6 @@ static StartCursor fromMessageId(MessageId messageId,
boolean inclusive) {
return new MessageIdStartCursor(messageId, inclusive);
}
- /**
- * This method is designed for seeking message from event time. But Pulsar
didn't support
- * seeking from message time, instead, it would seek the position from
publish time. We only
- * keep this method for backward compatible.
- *
- * @deprecated Use {@link #fromPublishTime(long)} instead.
- */
- @Deprecated
Review Comment:
I see. But I don't know where to add it? Since the Pulsar 4.0.0 will
introduce a lot of break changes. Maybe I can add these changes somewhere in
https://cwiki.apache.org/confluence/display/FLINK/1.17+Release?
##########
flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/cursor/StartCursor.java:
##########
@@ -73,18 +73,6 @@ static StartCursor fromMessageId(MessageId messageId,
boolean inclusive) {
return new MessageIdStartCursor(messageId, inclusive);
}
- /**
- * This method is designed for seeking message from event time. But Pulsar
didn't support
- * seeking from message time, instead, it would seek the position from
publish time. We only
- * keep this method for backward compatible.
- *
- * @deprecated Use {@link #fromPublishTime(long)} instead.
- */
- @Deprecated
Review Comment:
I see. But I don't know where to add it? Since the Pulsar 4.0.0 will
introduce a lot of breaking changes. Maybe I can add these changes somewhere in
https://cwiki.apache.org/confluence/display/FLINK/1.17+Release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
