[
https://issues.apache.org/jira/browse/FLINK-4731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552271#comment-15552271
]
ASF GitHub Bot commented on FLINK-4731:
---------------------------------------
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2584#discussion_r82211023
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsCheckpointStreamFactory.java
---
@@ -297,7 +296,7 @@ public StreamStateHandle closeAndGetHandle() throws
IOException {
if (outStream == null && pos <=
localStateThreshold) {
closed = true;
byte[] bytes =
Arrays.copyOf(writeBuffer, pos);
- return new
ByteStreamStateHandle(bytes);
+ return new
ByteStreamStateHandle(String.valueOf(createStatePath()), bytes);
--- End diff --
Why don't we do `createStatePath().toString()`? We actually don't want a
non-unique `"null"` String here in case that `createStatePath()` returns `null`
(which it shouldn't anyways).
> HeapKeyedStateBackend restoring broken for scale-in
> ---------------------------------------------------
>
> Key: FLINK-4731
> URL: https://issues.apache.org/jira/browse/FLINK-4731
> Project: Flink
> Issue Type: Bug
> Components: State Backends, Checkpointing
> Reporter: Stefan Richter
> Assignee: Stefan Richter
>
> Restoring the HeapKeyedStateBackend is broken in case that parallelism is
> reduced. The restore method is overwriting previously restored state.
> We should also add scale-in testing to the RescalingITCase.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
