[
https://issues.apache.org/jira/browse/FLINK-4731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552275#comment-15552275
]
ASF GitHub Bot commented on FLINK-4731:
---------------------------------------
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2584#discussion_r82217757
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/memory/ByteStreamStateHandle.java
---
@@ -20,62 +20,49 @@
import org.apache.flink.core.fs.FSDataInputStream;
import org.apache.flink.runtime.state.StreamStateHandle;
-import org.apache.flink.util.InstantiationUtil;
import org.apache.flink.util.Preconditions;
import java.io.IOException;
-import java.io.Serializable;
-import java.util.Arrays;
/**
* A state handle that contains stream state in a byte array.
*/
public class ByteStreamStateHandle implements StreamStateHandle {
- private static final long serialVersionUID = -5280226231200217594L;
+ private static final long serialVersionUID = -5280226231202517594L;
/**
- * the state data
+ * The state data.
*/
protected final byte[] data;
/**
+ * A unique name of by which this state handle is identified and
compared. Like a filename, all
+ * {@link ByteStreamStateHandle} with the exact same name must also
have the exact same content in data.
+ */
+ protected final String handleName;
--- End diff --
Is this meant to be an optimization for `equals/hashCode`? If yes, has it
been an issue before?
> HeapKeyedStateBackend restoring broken for scale-in
> ---------------------------------------------------
>
> Key: FLINK-4731
> URL: https://issues.apache.org/jira/browse/FLINK-4731
> Project: Flink
> Issue Type: Bug
> Components: State Backends, Checkpointing
> Reporter: Stefan Richter
> Assignee: Stefan Richter
>
> Restoring the HeapKeyedStateBackend is broken in case that parallelism is
> reduced. The restore method is overwriting previously restored state.
> We should also add scale-in testing to the RescalingITCase.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
