lsyldliu commented on code in PR #21629:
URL: https://github.com/apache/flink/pull/21629#discussion_r1070778492
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/endpoint/hive/HiveServer2Endpoint.java:
##########
@@ -310,7 +311,11 @@ public TOpenSessionResp OpenSession(TOpenSessionReq
tOpenSessionReq) throws TExc
// all the alive PersistenceManager in the ObjectStore, which may
get error like
// "Persistence Manager has been closed" in the later connection.
hiveCatalog.open();
- Module hiveModule = new HiveModule();
+ // create hive module lazily
+ FunctionCreator<Module> hiveModuleCreator =
+ (options, readableConfig, classLoader) ->
+ FactoryUtil.createModule(
Review Comment:
It uses the classloader in Context, and so is user classloader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
