JingsongLi commented on code in PR #480:
URL: https://github.com/apache/flink-table-store/pull/480#discussion_r1071001147
##########
flink-table-store-common/src/main/java/org/apache/flink/table/store/file/predicate/LeafPredicate.java:
##########
@@ -84,7 +99,10 @@ public List<Object> literals() {
@Override
public boolean test(Object[] values) {
Review Comment:
Maybe we can provide an interface instead of an object array for the input,
so we have the opportunity to create something similar to `CastedRow` to avoid
affecting the `LeafPredicate` code.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
