JingsongLi commented on code in PR #480:
URL: https://github.com/apache/flink-table-store/pull/480#discussion_r1071053187
##########
flink-table-store-spark/src/test/java/org/apache/flink/table/store/spark/SparkReadTestBase.java:
##########
@@ -129,12 +129,17 @@ public static void startMetastoreAndSpark() throws
Exception {
}
protected static SimpleTableTestHelper createTestHelper(Path tablePath)
throws Exception {
- RowType rowType =
- new RowType(
- Arrays.asList(
- new RowType.RowField("a", new IntType(false)),
- new RowType.RowField("b", new BigIntType()),
- new RowType.RowField("c", new VarCharType())));
+ return createTestHelper(
+ tablePath,
+ Arrays.asList(
+ new RowType.RowField("a", new IntType(false)),
+ new RowType.RowField("b", new BigIntType()),
+ new RowType.RowField("c", new VarCharType())));
+ }
+
+ protected static SimpleTableTestHelper createTestHelper(
Review Comment:
Can we stop using this class? Because Spark SQL can create tables, Spark SQL
can also write data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
