zentol commented on PR #5: URL: https://github.com/apache/flink-connector-hbase/pull/5#issuecomment-1383961066
> On the short term the necessary calsses can be copied over to achieve the e2e test externalization ASAP I'd like to avoid that because realistically a migration just won't happen if we don't force the issue, as it was the case for years. > downloading artifacts will be required by multiple connector E2E tests By and large we avoid the need for this in newer connector tests by relying on testcontainers. > The HBase e2e test also relies on the flink-sql-client-test JAR, which is currently not deployed to maven. Would that be an option to deploy that as well for future releases so it is not necessary to put thogether the deps by hand? Does it actually need it though? Why would executing a SQL statement require test utils? > The one and only HBase E2E test is [ignored](https://github.com/apache/flink/blob/b29d1055f9225d189603b5aeeacf3199e4c98636/flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/test/java/org/apache/flink/tests/util/hbase/SQLClientHBaseITCase.java#L70) since 2021 April (according to Jira, that issue should be resolved but we never removed the @Ignore itself), so do we still consider this as a release blocker? It never ran during the whole 1.16 dev. cycle. WDYT? That's a fair point and I'd actually be fine to continue without it (or creating a completely new one). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
