luoyuxia commented on PR #21676: URL: https://github.com/apache/flink/pull/21676#issuecomment-1386391577
> > > can the new DeleteFromFilterOperation extend the SinkModifyOperation? > > > > > > I think we can make DeleteFromFilterOperation implement ModifyOperation since `SinkModifyOperation` contains much other things that won't be needed in `DeleteFromFilterOperation`. > > @luoyuxia In addition to the semantics that DeleteFromFilterOperation is also a SinkModifyOperation, another reason is that not all features supported by SinkModifyOperation are unused, such as dynamicOptions, WDYT? Yes, aggree on it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
