luoyuxia commented on PR #21676: URL: https://github.com/apache/flink/pull/21676#issuecomment-1386565864
> one more question for the 2nd row-level delete: consider the delete query without a filter: "DELETE FROM t", does it work under 'REMAINING_ROWS' mode? the generated plan contains an empty values source, so the sink will receive nothing till finish, should we add some notes for this to remind connector developers? Yes, it works under 'REMAINING_ROWS' mode. That's true that the sink will recieive nothing. But I think we may not add a note for this case specially. IMO, if the mode is specified by 'REMAINING_ROWS' mode, the devs should understand the behavior and implement it just like `insert overwrite` which will delete the old data and write new data comming. It's nothing special when no data comming, it just is like it will skip write the data comming. If needed, I think we can note it in the document. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
