SinBex commented on code in PR #21634:
URL: https://github.com/apache/flink/pull/21634#discussion_r1073256359
##########
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/benchmark/scheduling/InitSchedulingStrategyBenchmark.java:
##########
@@ -20,20 +20,28 @@
import org.apache.flink.runtime.scheduler.benchmark.JobConfiguration;
import
org.apache.flink.runtime.scheduler.strategy.PipelinedRegionSchedulingStrategy;
+import org.apache.flink.runtime.scheduler.strategy.SchedulingStrategy;
+import
org.apache.flink.runtime.scheduler.strategy.VertexwiseSchedulingStrategy;
+
+import static
org.apache.flink.runtime.scheduler.benchmark.SchedulerBenchmarkUtils.createSchedulingStrategy;
/**
- * The benchmark of initializing {@link PipelinedRegionSchedulingStrategy} in
a STREAMING/BATCH job.
+ * The benchmark of initializing {@link PipelinedRegionSchedulingStrategy} or
{@link
+ * VertexwiseSchedulingStrategy} in a STREAMING/BATCH job.
*/
public class InitSchedulingStrategyBenchmark extends SchedulingBenchmarkBase {
+ JobConfiguration jobConfiguration;
Review Comment:
Yes, private is better. Fixed this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
