SinBex commented on code in PR #21634:
URL: https://github.com/apache/flink/pull/21634#discussion_r1073262413
##########
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/benchmark/scheduling/InitSchedulingStrategyBenchmarkTest.java:
##########
@@ -44,4 +46,20 @@ public void initSchedulingStrategyBenchmarkInBatchJob()
throws Exception {
benchmark.initSchedulingStrategy();
benchmark.teardown();
}
+
+ @Test
+ public void initSchedulingStrategyBenchmarkInAdaptiveBatchJob() throws
Exception {
Review Comment:
Yes, there is indeed no time-consuming operation at present, but other
benchmarks in scheduler have introduced PipelinedRegionSchedulingStrategy and
VertexWiseSchedulingStrategy, it may be better to be consistent here? At the
same time, if other time-consuming operations are introduced in
VertexWiseSchedulingStrategy in the future, we can also detect them in time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
