1996fanrui commented on PR #21690: URL: https://github.com/apache/flink/pull/21690#issuecomment-1387067816
Hi @lindong28 , as I understand, Piotr means `StreamTask` determines the `return value` of `boolean DataOutput#emitRecord`, but `boolean DataOutput#emitRecord` is self-contained for its caller. `SourceOperator` and `NetworkInput` are caller of `boolean DataOutput#emitRecord`, they shouldn't care the logic of `boolean DataOutput#emitRecord`, they just use the `return value` to do some corresponding logic. So `boolean DataOutput#emitRecord` is self-contained for its caller. In other words: A and B call the interface of C, and the `return value` of the interface of C is determined by D. I think the interface of C should be self-contained for A and B. And A and B should not care about the interface of C is determined by D. This should be a common scenario, that is: the logic or `return value` of the interface is affected by some parameters. And please correct me if I'm wrong. cc @pnowojski -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
