pnowojski commented on PR #21690: URL: https://github.com/apache/flink/pull/21690#issuecomment-1387115366
Yes, exactly @1996fanrui. @lindong28, indeed, there is an issue that incorrectly implemented caller can ignore the return value. But how is it worse compared to your proposal of passing separate `Supplier<Boolean>`? I would say that your proposal is even more risky, since the `Supplier<Boolean>` would be independent of the `DataOutput`, so it's even more likely that someone implementing/using `DataOutput` would forget or even not realise that there is some `Supplier<Boolean>` that should be passed and used per every `void DataOutput#emitRecord` call. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
