gyfora commented on code in PR #507:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/507#discussion_r1073708282


##########
flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/docs/CrdReferenceDoclet.java:
##########
@@ -210,7 +233,7 @@ public Void scan(Element e, Integer depth) {
                 case ENUM_CONSTANT:
                     out.println(
                             "| "
-                                    + e
+                                    + getJsonPropValueOfEnum(e)

Review Comment:
   I think this logic should be applied to all fields, not only enums. 
Currently only enums are affected but we could define @JsonProperty annotations 
on other fields in the future



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to