herunkang2018 opened a new pull request, #21746:
URL: https://github.com/apache/flink/pull/21746
## What is the purpose of the change
There is a bug in batch over window operator codegen, the comparator codegen
logic is wrong that member code incorrectly used in method body.
## Brief change log
- Pass generated member code to caller to place in RangeBoundComparator
class correctly.
## Verifying this change
tested in IT case:
`flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/OverWindowITCase.scala`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't
know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? ((yes / **no**))
- If yes, how is the feature documented? (not applicable / docs / JavaDocs
/ **not documented**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
