SmirAlex commented on code in PR #20919:
URL: https://github.com/apache/flink/pull/20919#discussion_r1084842890
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/lookup/CachingLookupFunction.java:
##########
@@ -107,12 +107,12 @@ public void open(FunctionContext context) throws
Exception {
numLoadFailuresCounter = new SimpleCounter();
cacheMetricGroup.numLoadFailuresCounter(numLoadFailuresCounter);
}
- // Initialize cache and the delegating function
- cache.open(cacheMetricGroup);
if (cache instanceof LookupFullCache) {
// TODO add Configuration into FunctionContext
- ((LookupFullCache) cache).open(new Configuration());
+ ((LookupFullCache) cache).setParameters(new Configuration());
Review Comment:
I added this block for future change. But now it's redundant, agree. Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
