SmirAlex commented on code in PR #20919:
URL: https://github.com/apache/flink/pull/20919#discussion_r1089060316
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/lookup/fullcache/ReloadTriggerContext.java:
##########
@@ -26,11 +26,11 @@
/** Runtime implementation of {@link CacheReloadTrigger.Context}. */
public class ReloadTriggerContext implements CacheReloadTrigger.Context {
- private final Runnable reloadTask;
+ private final CacheLoader cacheLoader;
private final Consumer<Throwable> reloadFailCallback;
- public ReloadTriggerContext(Runnable reloadTask, Consumer<Throwable>
reloadFailCallback) {
- this.reloadTask = reloadTask;
+ public ReloadTriggerContext(CacheLoader cacheLoader, Consumer<Throwable>
reloadFailCallback) {
Review Comment:
Agree, changed to functional interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
