twalthr commented on code in PR #21519:
URL: https://github.com/apache/flink/pull/21519#discussion_r1085506331
##########
flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java:
##########
@@ -1973,10 +1972,6 @@ public void onMatch(RelOptRuleCall call) {
call.transformTo(relBuilder.build());
}
- /** Deprecated, use {@link RemoveSingleAggregateRuleConfig} instead. *
*/
- @Deprecated
- public interface Config extends RemoveSingleAggregateRuleConfig {}
Review Comment:
Update lines number in the JavaDoc of this class?
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkFilterJoinRule.java:
##########
@@ -431,13 +431,16 @@ public void onMatch(RelOptRuleCall call) {
}
/** Rule configuration. */
- public interface Config extends FlinkFilterJoinRule.Config {
- FlinkJoinConditionPushRule.Config DEFAULT =
- EMPTY.withOperandSupplier(b ->
b.operand(Join.class).anyInputs())
- .as(FlinkJoinConditionPushRule.Config.class)
- .withSmart(true)
- .withPredicate((join, joinType, exp) -> true)
- .as(FlinkJoinConditionPushRule.Config.class);
+ @Value.Immutable(singleton = false)
+ @Value.Style(
+ get = {"is*", "get*"}, // Detect 'get' and 'is' prefixes in
accessor methods
+ init = "with*", // Builder initialization methods will have
'set' prefix
+ defaults = @Value.Immutable(copy = false))
Review Comment:
Could you explain this change? `Builder initialization methods will have
'set' prefix`?
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/physical/stream/WatermarkAssignerChangelogNormalizeTransposeRule.java:
##########
@@ -380,8 +384,12 @@ private final RelNode buildTreeInOrder(
}
/** Rule configuration. */
+ @Value.Immutable(singleton = false)
public interface Config extends RelRule.Config {
+ Config DEFAULT =
+
ImmutableWatermarkAssignerChangelogNormalizeTransposeRule.Config.builder().build();
Review Comment:
Please update the `README.md` in `flink-table-planner` and explain how the
config in rule works and how one can resolve errors if the class does not exist
yet. Is there another way except recompiling the module with Maven? I guess
annotation processing must be enabled in the IDE and correctly configured?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
