twalthr commented on code in PR #21519:
URL: https://github.com/apache/flink/pull/21519#discussion_r1091726434
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/physical/stream/WatermarkAssignerChangelogNormalizeTransposeRule.java:
##########
@@ -380,8 +384,12 @@ private final RelNode buildTreeInOrder(
}
/** Rule configuration. */
+ @Value.Immutable(singleton = false)
public interface Config extends RelRule.Config {
+ Config DEFAULT =
+
ImmutableWatermarkAssignerChangelogNormalizeTransposeRule.Config.builder().build();
Review Comment:
Great that you approached in the immutables community. Looking forward to a
better answer as it might slow down / confusion Flink contributors.
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/physical/stream/WatermarkAssignerChangelogNormalizeTransposeRule.java:
##########
@@ -380,8 +384,12 @@ private final RelNode buildTreeInOrder(
}
/** Rule configuration. */
+ @Value.Immutable(singleton = false)
public interface Config extends RelRule.Config {
+ Config DEFAULT =
+
ImmutableWatermarkAssignerChangelogNormalizeTransposeRule.Config.builder().build();
Review Comment:
Great that you approached in the immutables community. Looking forward to a
better answer as it might slow down / confuse Flink contributors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
