snuyanzin commented on code in PR #21519:
URL: https://github.com/apache/flink/pull/21519#discussion_r1085679541
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkFilterJoinRule.java:
##########
@@ -431,13 +431,16 @@ public void onMatch(RelOptRuleCall call) {
}
/** Rule configuration. */
- public interface Config extends FlinkFilterJoinRule.Config {
- FlinkJoinConditionPushRule.Config DEFAULT =
- EMPTY.withOperandSupplier(b ->
b.operand(Join.class).anyInputs())
- .as(FlinkJoinConditionPushRule.Config.class)
- .withSmart(true)
- .withPredicate((join, joinType, exp) -> true)
- .as(FlinkJoinConditionPushRule.Config.class);
+ @Value.Immutable(singleton = false)
+ @Value.Style(
+ get = {"is*", "get*"}, // Detect 'get' and 'is' prefixes in
accessor methods
+ init = "with*", // Builder initialization methods will have
'set' prefix
+ defaults = @Value.Immutable(copy = false))
Review Comment:
This is related to the next line
```java
public interface FlinkFilterJoinRuleConfig extends FlinkFilterJoinRule.Config
```
where `FlinkFilterJoinRule.Config` instead of `set` methods has `Config
withSmart(boolean smart);` and `Config withPredicate(Predicate predicate);`
By default it generates setters with `set` prefix. Via such configuration
it's possible to say that we need setters with `with` prefix to match
`FlinkFilterJoinRule.Config` methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
