kristoffSC commented on PR #21393: URL: https://github.com/apache/flink/pull/21393#issuecomment-1405227888
Hi @tsreaper I'm currently working on the refactoring to include your suggestions, it does look promising. I should have new version by the end of this week. I have a question though. Can we assume that variables/fields used in IF and WHILE conditions will be always class member variables? I'm looking at `DeclarationRewriter` and I wonder if we take such assumption or can IF/WHILE condition arguments can come from method parameters? If they can come from method parameters and if they are primitive values, then we should not rewrite such a method. I don't think that original IfStatementRewriter deal with that but maybe I don't see it. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
