gyfora commented on code in PR #514:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/514#discussion_r1088337843


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java:
##########
@@ -340,6 +341,11 @@ protected Configuration build() {
         // Set cluster config
         effectiveConfig.setString(KubernetesConfigOptions.NAMESPACE, 
namespace);
         effectiveConfig.setString(KubernetesConfigOptions.CLUSTER_ID, 
clusterId);
+
+        if (FlinkUtils.isZookeeperHAActivated(effectiveConfig)) {
+            effectiveConfig.setString(HighAvailabilityOptions.HA_CLUSTER_ID, 
clusterId);

Review Comment:
   In that case I would suggest using the namespace + name combination itself 
to get a unique resource identifier. That is basically the same logic for 
Kubernetes HA



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to